Greg Sheremeta has posted comments on this change.
Change subject: webadmin: 'remove' confirmation dialog message cleanup
......................................................................
Patch Set 1: Verified+1
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
Line 11: public abstract class AbstractConfirmationPopupView extends
AbstractModelBoundPopupView<ConfirmationModel> {
Line 12:
Line 13: @UiField
Line 14: @Ignore
Line 15: public HTML messageHTML = new HTML();
I was getting an NPE without this set, but I don't know what else I changed
that would have caused that. I suspect setting the default message in the
'remove' popup's contructor is what caused it. Must be some kind of timing
issue.
Since this is a @UiField, I'm not sure if it's correct for me to instantiate it.
GWT experts, please advise :)
Line 16:
Line 17: public AbstractConfirmationPopupView(EventBus eventBus,
CommonApplicationResources resources) {
Line 18: super(eventBus, resources);
Line 19: }
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java
Line 75: force = new EntityModelCheckBoxEditor(Align.RIGHT);
Line 76: force.setLabel(constants.forceRemove());
Line 77: this.constants= constants;
Line 78: this.messages = messages;
Line 79: setMessageToDefault();
this is the line to which I'm referring in the previous comment.
Line 80: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 81: ViewIdHandler.idHandler.generateAndSetIds(this);
Line 82: localize(constants);
Line 83: driver.initialize(this);
--
To view, visit http://gerrit.ovirt.org/20471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7411dec0eaf8d60cefff563988618f7c548eecce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
