Lior Vernia has posted comments on this change.
Change subject: engine: block editing migraion fields while VM !Down
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 1572:
Line 1573: @DefaultStringValue("Attach a VirtIO-SCSI controller when
running the VM")
Line 1574: String isVirtioScsiEnabledInfo();
Line 1575:
Line 1576: @DefaultStringValue("The fields under 'Start Running On' and
'Migration Options' aren't editable while the VM isn't down")
Well, of course it's preferable to have it disabled in the frontend as well,
but I assume you have good reason to keep it enabled.
Line 1577: String nonEditableMigrationFieldsWhileVmNotDownInfo();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 469: <t:tab>
Line 470: <t:DialogTab ui:field="hostTab">
Line 471: <t:content>
Line 472: <g:FlowPanel>
Line 473: <d:InfoIcon
ui:field="nonEditableWhileVmNotDownInfo"
addStyleNames="{style.labelToCoupleCoupleLeft}"/>
Exactly since it affects both sections I would put it in a separate line, as a
comment in italic. But it's your call.
Line 474: <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.runOnVmPopup}" />
Line 475: <g:VerticalPanel
addStyleNames="{style.runHostPanel}" verticalAlignment='ALIGN_MIDDLE'>
Line 476:
<e:EntityModelRadioButtonEditor ui:field="isAutoAssignEditor"
Line 477:
addStyleNames="{style.radioButton}" />
--
To view, visit http://gerrit.ovirt.org/20444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
