Maor Lipchuk has posted comments on this change. Change subject: core : lock correct volume when creating a template ......................................................................
Patch Set 4: (4 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-10-23 11:52:43 +0300 Line 4: Commit: Liron Aravot <[email protected]> Line 5: CommitDate: 2013-10-24 13:26:17 +0300 Line 6: Line 7: core : lock correct volume when creating a template You also changed the importVMCommand Line 8: Line 9: When creating a template out of a vm, CreateImageTemplateCommand is Line 10: being called for each of the needed vm disks. In that command there all the Line 11: disk snapshots are being loaded in order to lock the active disk Line 6: Line 7: core : lock correct volume when creating a template Line 8: Line 9: When creating a template out of a vm, CreateImageTemplateCommand is Line 10: being called for each of the needed vm disks. In that command there all the /s/there// Line 11: disk snapshots are being loaded in order to lock the active disk Line 12: snapshot. Line 13: Line 14: That logic caused for 2 bugs in that command: Line 10: being called for each of the needed vm disks. In that command there all the Line 11: disk snapshots are being loaded in order to lock the active disk Line 12: snapshot. Line 13: Line 14: That logic caused for 2 bugs in that command: /s/caused for/caused by Line 15: 1. The lock is done always on a wrong disk snapshot, as Line 16: ImagesHandler.getAllImageSnapshots() will always return the active Line 17: images as first on the list, and ImagesHandler.getActiveVolume() returns Line 18: the last on the list, the lock won't be performed on the active volume. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 306: return true; Line 307: } Line 308: Line 309: protected DiskImage getActiveVolumeDisk(List<DiskImage> diskList) { Line 310: return diskList.get(diskList.size() - 1); What is the reason of that change? why not using ImagesHandler Line 311: } Line 312: Line 313: /** Line 314: * Load images from Import/Export domain. -- To view, visit http://gerrit.ovirt.org/20477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f27535de8ec6e007035ffa7a2e5fad80460701a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
