Kanagaraj M has posted comments on this change.

Change subject: webadmin : Moved Size-converter to backend utils
......................................................................


Patch Set 1:

(3 comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-10-24 17:03:29 +0530
Line 6: 
Line 7: webadmin : Moved Size-converter to backend utils
Line 8: 
Line 9: Moved Size-converter to backend utils
Also explain why this move is required.
Line 10: 
Line 11: Change-Id: I650436e48cdc0fc1c73f86d3424c9f5153e453d0


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/SizeConverter.java
Line 1: package org.ovirt.engine.core.common.utils.gluster;
move it to common.utils itself.
Line 2: 
Line 3: public class SizeConverter {
Line 4: 
Line 5:     public static final long CONVERT_FACTOR = 1024L;


....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 285:               <include name="common/action/gluster/*.java"/>
Line 286:               <include name="common/queries/gluster/*.java"/>
Line 287:               <include 
name="common/constants/gluster/GlusterConstants.java"/>
Line 288:               <include 
name="common/utils/gluster/GlusterCoreUtil.java"/>
Line 289:               <include 
name="common/utils/gluster/SizeConverter.java"/>
move this above in the file where the remaining util classes are defined.
Line 290:               <!-- Scheduling -->
Line 291:               <include name="common/scheduling/*.java"/>
Line 292:               <include name="common/scheduling/parameters/*.java"/>
Line 293:       </source>


-- 
To view, visit http://gerrit.ovirt.org/20506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I650436e48cdc0fc1c73f86d3424c9f5153e453d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to