Omer Frenkel has posted comments on this change.
Change subject: core: Detect host in idle prep for maintenance and re-migrate
......................................................................
Patch Set 17:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
Line 318: }
Line 319: }
Line 320:
Line 321: @Override
Line 322: public void vdsIdlingInPreparingForMaintenance(final VDS vds) {
still not sure about the name, maybe something like retryMaintenance ?
Line 323: // try to put the host to Maintenance again.
Line 324:
Backend.getInstance().runInternalAction(VdcActionType.MaintenanceNumberOfVdss,
Line 325: new
MaintenanceNumberOfVdssParameters(Arrays.asList(vds.getId()), true));
Line 326: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 109: }
Line 110:
Line 111: private void addMigratedVmsNotUpYet() {
Line 112: for (VM incomingVm :
getVmDAO().getAllMigratingToHost(getVdsId())) {
Line 113: if (incomingVm.getStatus() == VMStatus.MigratingTo) {
maybe not for this patch, but im thinking maybe we should move to unknown all
vms that migrating to this host, if a vm still exist on source host, it will be
updated back to migrating from (probably, maybe paused also).
this will keep us on the safe side
Line 114: // this VM is finished the migration handover and is
running on this host now
Line 115: // and should be treated as well.
Line 116: getVmList().add(incomingVm);
Line 117: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1533: GlanceImageTotalListSize,
Line 1534:
Line 1535: @TypeConverterAttribute(Integer.class)
Line 1536: @DefaultValueAttribute("300000")
Line 1537: HostPreparingForMaintenanceIdleTime,
i dont think there is some convention, but we usually use seconds, it also
makes more sense in this case, as no one would want this to happen in less than
1 second
Line 1538:
Line 1539: Invalid;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1867: _vds.getId(),
Line 1868: _vds.getName());
Line 1869: } else {
Line 1870: if (System.currentTimeMillis() -
_vdsManager.getStatusChangedTime() > Config.<Integer>
GetValue(ConfigValues.HostPreparingForMaintenanceIdleTime)) {
Line 1871:
ResourceManager.getInstance().getEventListener().vdsIdlingInPreparingForMaintenance(_vds);
no need to set the statusChangedTime to now? i am not sure it will be set again
(as current status is already preparingFor..)
Line 1872: }
Line 1873: }
Line 1874: }
Line 1875: }
--
To view, visit http://gerrit.ovirt.org/17942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e18bcfbc566b6fd92d276c5c739ba607e2a53f0
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
