Lior Vernia has posted comments on this change.
Change subject: webadmin: radiobutton text is truncated & unaligned
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Adding the CSS expert to see there might be a more elegant way to achieve
this...
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
Line 145:
Line 146: @Template("<div style='max-width: 500px; word-wrap:break-word;
font-style: italic;'>{0}</div>")
Line 147: SafeHtml italicWordWrapMaxWidth(String text);
Line 148:
Line 149: @Template("<div style='width:90%; display:inline-block;
vertical-align: top;'>{0}</div>")
Is "vertical-align: top" needed? Doesn't it look same/better without it / with
"vertical-align: middle"?
Line 150: SafeHtml radioButtonLabel(String text);
--
To view, visit http://gerrit.ovirt.org/20580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
