Liron Ar has posted comments on this change.
Change subject: core: deadlock and related changes in domain
monitoring/InitVdsOnUp
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 284:
Line 285: // Now update the status of domains, this code should
not be in
Line 286: // synchronized part of code
Line 287: if (domainsList != null) {
Line 288: IrsBrokerCommand.UpdateVdsDomainsData(_vds,
storagePoolId, domainsList);
Done
Line 289: }
Line 290: } catch (Exception e) {
Line 291: log.error("Timer update runtimeinfo failed.
Exception:", e);
Line 292: } finally {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 95: * @param vdsDomainData
Line 96: */
Line 97: public static void UpdateVdsDomainsData(VDS vds, Guid
storagePoolId,
Line 98: ArrayList<VDSDomainsData> vdsDomainData) {
Line 99: if (vds.getStatus() == VDSStatus.Up) {
as this method is called only from vds manager and there null is already check,
i think that adding here also here is unneeded atm.
Line 100: IrsProxyData proxy = _irsProxyData.get(storagePoolId);
Line 101: if (proxy != null) {
Line 102: proxy.UpdateVdsDomainsData(vds.getId(),
vds.getName(), vdsDomainData);
Line 103: }
--
To view, visit http://gerrit.ovirt.org/20400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I334b450fcf29ed57675ec1f2e4bf3bc43f31b4aa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
