Vitor de Lima has posted comments on this change.

Change subject: core, engine, webadmin: Cluster and architecture related changes
......................................................................


Patch Set 4:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 92:         if (getTargetCluster().supportsGlusterService() && 
!hasUpServerInTarget(getTargetCluster())) {
Line 93:             return false;
Line 94:         }
Line 95: 
Line 96:         if (vds.getCpuName() == null) {
Done
Line 97:             
vds.setCpuName(CpuFlagsManagerHandler.FindMaxServerCpuByFlags(vds.getCpuFlags(),
Line 98:                     getTargetCluster().getcompatibility_version()));
Line 99:         }
Line 100: 


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java
Line 23: @NonTransactiveCommandAttribute
Line 24: public class HandleVdsCpuFlagsOrClusterChangedCommand<T extends 
VdsActionParameters> extends VdsCommand<T> {
Line 25: 
Line 26:     private boolean _hasFlags = true;
Line 27:     private boolean _foundCPU = true;
Done
Line 28:     private boolean _architectureMismatch = false;
Line 29: 
Line 30:     public HandleVdsCpuFlagsOrClusterChangedCommand(T parameters) {
Line 31:         super(parameters);


-- 
To view, visit http://gerrit.ovirt.org/18226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If19c3ee99f5ef17721bb4111ddfb48977d1b578b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to