Sergey Gotliv has posted comments on this change. Change subject: webadmin: Allow to configure disk as read only when attach it to VM ......................................................................
Patch Set 2: (2 comments) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java Line 384: } Line 385: }; Line 386: internalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "95px"); //$NON-NLS-1$ Line 387: Line 388: SafeHtml readOnlyColumnHeader = templates.imageWithTitle(SafeHtmlUtils.fromTrustedString( getHeaderHtml() is a method of ImageResourceColumn class while DisksViewColumns.readOnlyCheckboxColumn is an instance of CheckboxColumn class which is not implementing that method. Line 389: AbstractImagePrototype.create(resources.readOnlyDiskIcon()).getHTML()), constants.readOnly() Line 390: ); Line 391: internalDiskTable.addColumn(DisksViewColumns.readOnlyCheckboxColumn, readOnlyColumnHeader, "30px"); //$NON-NLS-1$ Line 392: Line 506: } Line 507: }; Line 508: externalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "90px"); //$NON-NLS-1$ Line 509: Line 510: SafeHtml readOnlyColumnHeader = templates.imageWithTitle(SafeHtmlUtils.fromTrustedString( Same :-) Line 511: AbstractImagePrototype.create(resources.readOnlyDiskIcon()).getHTML()), constants.readOnly() Line 512: ); Line 513: externalDiskTable.addColumn(DisksViewColumns.readOnlyCheckboxColumn, readOnlyColumnHeader, "30px"); //$NON-NLS-1$ Line 514: -- To view, visit http://gerrit.ovirt.org/20454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bf1408371958d8522c5e6f486c75d1e32788f48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
