Liran Zelkha has uploaded a new change for review. Change subject: engine : Remove unneeded VdsDynamic updates ......................................................................
engine : Remove unneeded VdsDynamic updates VdsUpdateRuntimeInfo updates VdsDynamic even if it hasn't changed. This patch fixes it, and reduces the number of DB updates. Change-Id: I0254991f424490d848f84fc951e64787bf54d7bc Bug-Url: https://bugzilla.redhat.com/1016634 Signed-off-by: [email protected] <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/20643/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java index ab615a6..194404a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java @@ -369,7 +369,12 @@ * @param dynamicData */ public void UpdateDynamicData(VdsDynamic dynamicData) { - DbFacade.getInstance().getVdsDynamicDao().update(dynamicData); + if (dynamicData != null && _vds != null && _vds.getDynamicData() != null + && !dynamicData.equals(_vds.getDynamicData())) { + DbFacade.getInstance().getVdsDynamicDao().update(dynamicData); + } else { + log.debug("Ignoring unneeded update of VDSDynamic"); + } } /** -- To view, visit http://gerrit.ovirt.org/20643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0254991f424490d848f84fc951e64787bf54d7bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
