Lior Vernia has posted comments on this change.
Change subject: webadmin: Rendered checkbox headers resizeable
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java
Line 12: import com.google.gwt.user.cellview.client.Column;
Line 13:
Line 14: public class ResizeableCheckboxHeader<T> extends ResizableHeader<T> {
Line 15:
Line 16: CheckboxHeader checkboxHeaderDelegate;
Correct me if I'm wrong, but this way you'd lose the tooltip capabilities for a
checkbox header that had been resized small enough to cut the text, right?
Currently the checkbox header is both resizeable and displays a correct tooltip
when appropriate, so that seems preferable.
Line 17:
Line 18: public ResizeableCheckboxHeader(CheckboxHeader checkboxHeader,
Line 19: Column<T, ?> column,
Line 20: HasResizableColumns<T> table) {
Line 29: checkboxHeaderDelegate = checkboxHeader;
Line 30: }
Line 31:
Line 32: @Override
Line 33: public void onBrowserEvent(Context context, Element target,
NativeEvent event) {
Done
Line 34: if
(checkboxHeaderDelegate.getCell().getConsumedEvents().contains(event.getType()))
{
Line 35: checkboxHeaderDelegate.onBrowserEvent(context, target,
event);
Line 36: } else {
Line 37: super.onBrowserEvent(context, target, event);
--
To view, visit http://gerrit.ovirt.org/20324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie442350893282e7838e5216d277718e654f1d884
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
