Tal Nisan has posted comments on this change.

Change subject: core: Add audit log for export repo image
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 86: USER_FAILED_ADD_DISK=Operation Add-Disk failed (User: ${UserName}).
Line 87: USER_IMPORT_IMAGE=User ${UserName} importing image ${RepoImageName} to 
domain ${StorageDomainName}.
Line 88: USER_IMPORT_IMAGE_FINISHED_SUCCESS=User ${UserName} successfully 
imported image ${RepoImageName} to domain ${StorageDomainName}.
Line 89: USER_IMPORT_IMAGE_FINISHED_FAILURE=User ${UserName} failed to import 
image ${RepoImageName} to domain ${StorageDomainName}.
Line 90: USER_EXPORT_IMAGE=User ${UserName} exporting image ${RepoImageName} 
from domain ${StorageDomainName}.
The RepoImageName message variable is not set and will probably appear as 
'RepoImageName' for every image, add a getRepoImageName() method as in 
ImportRepoImageCommand
Line 91: USER_EXPORT_IMAGE_FINISHED_SUCCESS=User ${UserName} successfully 
exported image ${RepoImageName} from domain ${StorageDomainName}.
Line 92: USER_EXPORT_IMAGE_FINISHED_FAILURE=User ${UserName} failed to export 
image ${RepoImageName} from domain ${StorageDomainName}.
Line 93: USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_SRC_IMAGE=Possible failure 
while deleting ${DiskAlias} from the source Storage Domain ${StorageDomainName} 
during the move operation. The Storage Domain may be manually cleaned-up from 
possible leftovers (User:${UserName}).
Line 94: USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_DST_IMAGE=Possible failure 
while clearing possible leftovers of ${DiskAlias} from the target Storage 
Domain ${StorageDomainName} after the move operation failed to copy the image 
to it properly. The Storage Domain may be manually cleaned-up from possible 
leftovers (User:${UserName}).


-- 
To view, visit http://gerrit.ovirt.org/20660
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb79102b01b596a1ff74a1a38fdcb7dca71e0c7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to