Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove GetAllServerCpuListParameters class
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 1720: }
Line 1721: };
Line 1722: VdcQueryParametersBase params = new VdcQueryParametersBase();
Line 1723: params.addParameter(GenericVdcParameter.Version, version);
Line 1724: Frontend.RunQuery(VdcQueryType.GetAllServerCpuList, params,
aQuery);
I suggest to explore:
Frontend.RunQuery(
VdcQueryType.GetAllServerCpuList,
new VdcQueryParameterBase().addParameter(
GenericVdcParameter.Version, version
),
aQuery
)
I know java people likes temp vars... unsure why... but work mentioning... if
there are multiple parameters...
Frontend.RunQuery(
VdcQueryType.GetAllServerCpuList,
new VdcQueryParameterBase().addParameter(
GenericVdcParameter.Version, version
).addParameter(
xxx, xxx
).addParameter(
xxx, xxx
).addParameter(
xxx, xxx
).addParameter(
xxx, xxx
).addParameter(
xxx, xxx
),
aQuery
)
Line 1725: }
Line 1726:
Line 1727: public static void getPmTypeList(AsyncQuery aQuery, Version
version) {
Line 1728: aQuery.converterCallback = new IAsyncConverter() {
--
To view, visit http://gerrit.ovirt.org/20416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
