Michael Kublin has posted comments on this change.
Change subject: core: unable to start vm: incorrect boot order sent in
CreateVmVdsCommand
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 71: oldVmDevice.setIsPlugged(!oldVmDevice.getIsPlugged());
I think u can start transaction from here line 72
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 284: for (DiskImage image : vmBase.getDiskList()) {
please use image.getId() ,image.getimage_group_id() is deprecated from now
--
To view, visit http://gerrit.ovirt.org/3332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I086e06b7119132ee17c8624b69ea863e0b54c3bd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
