Timothy Asir has posted comments on this change.
Change subject: gluster: add gluster host uuid along with host name/ip for
remove host
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 210: handleError(-1, "No host in Up status found in source
cluster");
Line 211: errorType = AuditLogType.GLUSTER_SERVER_REMOVE_FAILED;
Line 212: return false;
Line 213: }
Line 214: Guid serverId = runningHostInSourceCluster.getId();
Done
Line 215: GlusterServer glusterServer =
getDbFacade().getGlusterServerDao().getByServerId(serverId);
Line 216: Guid glusterHostId =
Line 217: (glusterServer != null) ?
glusterServer.getGlusterServerUuid() : null;
Line 218: if (glusterHostId == null) {
Line 213: }
Line 214: Guid serverId = runningHostInSourceCluster.getId();
Line 215: GlusterServer glusterServer =
getDbFacade().getGlusterServerDao().getByServerId(serverId);
Line 216: Guid glusterHostId =
Line 217: (glusterServer != null) ?
glusterServer.getGlusterServerUuid() : null;
yes, I will update this and resubmit the patch
Line 218: if (glusterHostId == null) {
Line 219: handleError(-1, "Failed to get gluser UUID for the host:"
+ hostName);
Line 220: errorType = AuditLogType.GLUSTER_SERVER_REMOVE_FAILED;
Line 221: return false;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 203: if (glusterHostId == null) {
Line 204: handleError(-1, "Failed to get gluser UUID for the
host:" + getVds().getId());
Line 205: errorType = AuditLogType.GLUSTER_SERVER_REMOVE_FAILED;
Line 206: return;
Line 207: }
Done
Line 208: VDSReturnValue returnValue =
Line 209: runVdsCommand(
Line 210: VDSCommandType.RemoveGlusterServer,
Line 211: new
RemoveGlusterServerVDSParameters(upServer.getId(),
--
To view, visit http://gerrit.ovirt.org/20731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I799333a16dfffaa6125aa6d498e4292cbb97cf48
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
