Ramesh N has uploaded a new change for review. Change subject: webadmin: add dash - before every items in the remove brick confirmation pop up ......................................................................
webadmin: add dash - before every items in the remove brick confirmation pop up Adding a dash (-) before every item in the remove brick confirmation pop up Change-Id: I65d43615162ea1274207e49fefcbb270d707d79c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024734 Signed-off-by: Ramesh Nachimuthu <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/20742/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java index 9e60c9e..743ead5 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java @@ -92,7 +92,7 @@ @Provides @Singleton public SearchableDetailModelProvider<GlusterBrickEntity, VolumeListModel, VolumeBrickListModel> getVolumeBrickListProvider(EventBus eventBus, - Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, + final Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, final Provider<AddBrickPopupPresenterWidget> addBrickPopupProvider, final Provider<RemoveBrickPopupPresenterWidget> removeConfirmPopupProvider, final Provider<RemoveBrickPopupPresenterWidget> removeBrickPopupProvider, @@ -130,7 +130,7 @@ if (lastExecutedCommand == getModel().getRemoveBricksCommand()) { return removeConfirmPopupProvider.get(); } else { - return super.getConfirmModelPopup(source, lastExecutedCommand); + return defaultConfirmPopupProvider.get(); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java index 9eb189f..ba04508 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java @@ -108,7 +108,7 @@ ArrayList<String> items = (ArrayList<String>) object.getItems(); for (String item : items) { - itemsPanel.add(new Label(item)); + itemsPanel.add(new Label(getItemTextFormatted(item))); } } }); @@ -132,6 +132,10 @@ }); } + private String getItemTextFormatted(String itemText) { + return "- " + itemText; //$NON-NLS-1$ + } + @Override public void setMessage(String message) { super.setMessage(message); -- To view, visit http://gerrit.ovirt.org/20742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65d43615162ea1274207e49fefcbb270d707d79c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
