Moti Asayag has posted comments on this change.
Change subject: core: simplified RunVmValidator#validateNetworkInterfaces
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 505:
Line 506: private Set<String> getInterfaceNetworkNames() {
Line 507: if (cachedInterfaceNetworkNames == null) {
Line 508: return
Entities.vmInterfacesByNetworkName(vm.getInterfaces()).keySet();
Line 509: }
could you add a space line here, before the return ?
Line 510: return cachedInterfaceNetworkNames;
Line 511: }
Line 512:
Line 513: private List<Network> getClusterNetworks() {
Line 512:
Line 513: private List<Network> getClusterNetworks() {
Line 514: if (cachedClusterNetworks == null) {
Line 515: cachedClusterNetworks =
getNetworkDao().getAllForCluster(vm.getVdsGroupId());
Line 516: }
same
Line 517: return cachedClusterNetworks;
Line 518: }
Line 519:
Line 520: private Set<String> getClusterNetworksNames() {
Line 519:
Line 520: private Set<String> getClusterNetworksNames() {
Line 521: if (cachedClusterNetworksNames == null) {
Line 522: cachedClusterNetworksNames =
Entities.objectNames(getClusterNetworks());
Line 523: }
same
Line 524: return cachedClusterNetworksNames;
Line 525: }
--
To view, visit http://gerrit.ovirt.org/18243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21540687322f2fca09b723572f96c3a7ce6a207a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
