Lior Vernia has posted comments on this change. Change subject: webadmin: add dash - before items in confirmation pop up ......................................................................
Patch Set 2: Code-Review+1 I don't feel comfortable giving +2 as I'm not familiar with the uses of DefaultConfirmationPopupView throughout the frontend, there are a lot of references to it and this could potentially cause some regression (nothing major but maybe hurt how some things are displayed). Vojtech might know better. -- To view, visit http://gerrit.ovirt.org/20730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib09a5ca23e81e2c11e64e08084691ebc03e2f602 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
