Vojtech Szocs has posted comments on this change.
Change subject: core: rearrange product uris
......................................................................
Patch Set 13:
(3 comments)
....................................................
File backend/manager/modules/docs/pom.xml
Line 65:
Line 66: <dependency>
Line 67: <groupId>${engine.groupId}</groupId>
Line 68: <artifactId>branding</artifactId>
Line 69: <version>${engine.version}</version>
OK, maybe we should investigate that, for now I'm fine with current approach.
Line 70: </dependency>
Line 71: </dependencies>
Line 72:
Line 73: <build>
....................................................
File backend/manager/modules/services/pom.xml
Line 53: <plugins>
Line 54:
Line 55: <plugin>
Line 56: <groupId>org.apache.maven.plugins</groupId>
Line 57: <artifactId>maven-war-plugin</artifactId>
Thanks, if it turns out to be redundant I suggest to remove it.
Line 58: </plugin>
Line 59: </plugins>
Line 60: </build>
Line 61:
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java
Line 120:
Line 121: /**
Line 122: * Forward the request to the appropriate servlet in the context
specified in the init method. This works
Line 123: * for all verbs due to the fact that forward calls service in
the target servlet, which determines which
Line 124: * verb was used based on the request object.
You're right, thanks for explaining that.
Line 125: *
Line 126: * If the initialization of the {@code ForwardServlet} includes
special parameters with a key starts with
Line 127: * 'attr-' those keys and values will be added to the request
attributes for use in the target servlet. The
Line 128: * 'attr-' prefix will be stripped from attribute key.
--
To view, visit http://gerrit.ovirt.org/20473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
