Oved Ourfali has posted comments on this change. Change subject: core: Modify Serializer.serialize(Serialize) signature ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) Just look at the minor comment regarding the javadoc method comment. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Serializer.java Line 12: * @throws SnapshotSerializationExeption Can you fix the name of the exception here as well? Should be SerializationException and not SnapshotSerializationException. Can be done as part of a different patch if you prefer. -- To view, visit http://gerrit.ovirt.org/3780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3089b8f05c134807bd5a4e3498ea059e14ab858b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
