Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: workaround for Firefox favicon bug ......................................................................
Patch Set 1: (1 comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java Line 65: // Handle UI logout requests Line 66: user.setLogoutHandler(this); Line 67: Line 68: // workaround favicon-missing bug in Firefox Line 69: registerHistoryChangeHandler(); I just tested removing it and it's fine. The question is -- do we want to safeguard against this happening somewhere else in the app? We haven't yet seen it, but since it's a know FF bug, it could happen. Thoughts? Line 70: Line 71: // Initialize UiCommon infrastructure Line 72: initUiCommon(); Line 73: initFrontend(); -- To view, visit http://gerrit.ovirt.org/20798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
