Sergey Gotliv has posted comments on this change.
Change subject: provider: IllegalStateException in getCowVirtualSize
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java
Line 325: } finally {
Line 326: try {
Line 327: downloadImage.getInputStream().close();
Line 328: } catch (IOException|IllegalStateException e) {
Line 329: // Silently skip IOException and
IllegalStateException errors
I assume that this code want to swallow every possible exception. It just
relies on the underlying api which currently throws only these two.
If this is the case why it doesn't catch general Exception? I believe it not so
bad in this case.
Line 330: }
Line 331: }
Line 332:
Line 333: ByteBuffer b = ByteBuffer.wrap(imgContent);
--
To view, visit http://gerrit.ovirt.org/20782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20b816c49e60763f4f5b930f309365c0c770e1cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
