Michael Pasternak has posted comments on this change. Change subject: cli: Using true as a default for boolean flags(#1006918) ......................................................................
Patch Set 1: (1 comment) .................................................... File src/ovirtcli/command/command.py Line 200: """INTERNAL: set data in to property""" Line 201: if hasattr(obj, prop) and type(getattr(obj, prop)) == bool and val == None: Line 202: return Line 203: if hasattr(obj, prop + '_') and type(getattr(obj, prop + '_')) == bool and val == None: Line 204: return ravi, can you please explain how this patch addresses mentioned RFE?, IMHO you should be setting manually True where val is None ... Line 205: Line 206: if hasattr(obj, prop): Line 207: setattr(obj, prop, val) Line 208: elif hasattr(obj, prop + '_'): -- To view, visit http://gerrit.ovirt.org/20804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie87885a1219b20967241bde4e91b363355a5ea51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
