Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add answerfile option ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/ovirt-engine-reports-setup.py Line 1096: Line 1097: if not warUpdated and DB_EXIST: Line 1098: #backupWAR() Line 1099: #backupDB(db_dict, TEMP_PGPASS) Line 1100: pass not really needed, I think you can just remove the whole if here. Line 1101: Line 1102: # Catch failures on configuration Line 1103: try: Line 1104: # Export reports if we had a previous installation -- To view, visit http://gerrit.ovirt.org/20837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a1bd52965f0f16f68ac9948622d22f1299edef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
