Vojtech Szocs has posted comments on this change.
Change subject: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java
Line 102: public void onKeyPress(KeyPressEvent event) {
Line 103: Scheduler.get().scheduleDeferred(new
ScheduledCommand() {
Line 104: @Override
Line 105: public void execute() {
Line 106:
ValueChangeEvent.fire(nameEditor.asValueBox(),
nameEditor.asValueBox().getValue());
IIUC, this way the key press handler triggers ValueChangeEvent on nameEditor's
input element (i.e. value box), which in turn triggers ValueChangeEvent on
VnicProfileWidget (code below) ?
Line 107: }
Line 108: });
Line 109: }
Line 110: });
--
To view, visit http://gerrit.ovirt.org/20492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
