Vojtech Szocs has posted comments on this change.
Change subject: frontend: introduce generics to UICommon (part 3)
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
I'd give +2 but others (Daniel, Gilad, Alona, Tal) should also review, for me
the patch looks good.
(Just one small inline comment.)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelRadioButton.java
Line 90: public void setValue(Boolean value) {
Line 91: asRadioButton().setValue(value);
Line 92: }
Line 93:
Line 94: @SuppressWarnings({ "rawtypes", "unchecked" })
Do we still need to suppress rawtypes warning? i.e. can't we use
ValueChangeHandler<Boolean> here?
Line 95: @Override
Line 96: public HandlerRegistration
addValueChangeHandler(ValueChangeHandler handler) {
Line 97: return asRadioButton().addValueChangeHandler(handler);
Line 98: }
--
To view, visit http://gerrit.ovirt.org/20864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c221076b706d77c7c1facfbd5d668a2082df72
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
