Moti Asayag has posted comments on this change.
Change subject: core: attach network to cluster supports update as well
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File backend/manager/dbscripts/network_sp.sql
Line 741: Create or replace FUNCTION
set_network_exclusively_As_display(v_cluster_id UUID,
s/As/as
pls replace the tab with spaces
Line 751:
this will affect other DCs as well, not just the specific cluster DC
isn't there a need to restrict it?
e.g:
WHERE
cluster_id != v_cluster_id AND network_id = v_network_id;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAODbFacadeImpl.java
Line 110:
getCallsHandler().executeModification("set_network_exclusively_As_display",
parameterSource);
in case you rename the STP all to lower case, same here
....................................................
Commit Message
Line 11: To set a network as a display network simlpy set display true and
s/simlpy/simply
--
To view, visit http://gerrit.ovirt.org/3679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55f33772b5ee7344a2417005a85e7219f6a547af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
