Allon Mureinik has posted comments on this change. Change subject: core: Make commited_disk_size view column show total virtual size ......................................................................
Patch Set 1: (4 comments) I'd also add an additional assertion somewhere in StorageDomainDAOTest, just to make sure you're getting the right behavior. .................................................... Commit Message Line 6: Line 7: core: Make commited_disk_size view column show total virtual size Line 8: Line 9: In the storage views the commited_disk_size column is supposed to show the Line 10: total amount of the disks virtual sizes (commited size) in practice this s/ in practice/. In practice/ Line 11: column shows the commited size minus the provisioned size of the disk, this Line 12: was fixed to show the commited size alone as the provisioned size is shown Line 13: already in used_disk_size and is not needed Line 14: Line 7: core: Make commited_disk_size view column show total virtual size Line 8: Line 9: In the storage views the commited_disk_size column is supposed to show the Line 10: total amount of the disks virtual sizes (commited size) in practice this Line 11: column shows the commited size minus the provisioned size of the disk, this s/of the disk, this/of the disks. This/ Line 12: was fixed to show the commited size alone as the provisioned size is shown Line 13: already in used_disk_size and is not needed Line 14: Line 15: Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4 Line 8: Line 9: In the storage views the commited_disk_size column is supposed to show the Line 10: total amount of the disks virtual sizes (commited size) in practice this Line 11: column shows the commited size minus the provisioned size of the disk, this Line 12: was fixed to show the commited size alone as the provisioned size is shown s/alone/only/ Line 13: already in used_disk_size and is not needed Line 14: Line 15: Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4 Line 16: Bug-Url: https://bugzilla.redhat.com/1025294 .................................................... File packaging/dbscripts/create_functions.sql Line 350: BEGIN Line 351: mult := ( SELECT Line 352: COALESCE(SUM(images_storage_domain_view.size),0) Line 353: FROM images_storage_domain_view JOIN Line 354: disk_image_dynamic ON ( images_storage_domain_view.image_guid = disk_image_dynamic.image_id ) You no longer have any columns form disk_image_dynamic - you should remove the join. Line 355: WHERE Line 356: images_storage_domain_view.storage_id = v_storage_domain_id ); Line 357: -- convert to GB from bytes Line 358: mult := CAST((mult * 0.000000000931322574615478515625) AS bigint); -- To view, visit http://gerrit.ovirt.org/20930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
