Omer Frenkel has posted comments on this change.
Change subject: core: send mount_options only if 3.1
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 83: if (storage_pool != null &&
storage_pool.getcompatibility_version().compareTo(Version.v3_1) >= 0) {
there is another way to check if operation is allowed by version,
instead of hardcoding this in the code, you can use configuration,
check out example in: CreateStorageDomainVDSCommand
--
To view, visit http://gerrit.ovirt.org/3802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5af895188d6b74ecb0faed21c52a50c12641631
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
