Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: fix DB detection and owner from previous 
versions
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/common_utils.py
Line 1202:     return True
Line 1203: 
Line 1204: 
Line 1205: def updateDbOwner(db_dict):
Line 1206:     logging.debug('Updating DB owner')
Please take a look at /usr/share/ovirt-engine/setup/dbutils/changedbowner.sh.

If that's enough for you you can avoid code duplication here :-)
Line 1207:     _RE_OWNER = re.compile(r'^([\w,.\(\)]+\s+)+OWNER TO 
(?P<owner>\w+).*$')
Line 1208:     out, rc = runPostgresSuCommand(
Line 1209:         command=EXEC_PGDUMP,
Line 1210:         database=db_dict['dbname'],


-- 
To view, visit http://gerrit.ovirt.org/20154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fe256660b233bc682dc22e79cf58d34c546c3a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to