Lior Vernia has posted comments on this change.
Change subject: webadmin: cpu pinning is disabled for Local SD
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 701: compatibilityVersion))) {
Line 702: hasCpuPinning = false;
Line 703: } else if
(Boolean.FALSE.equals(AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.CpuPinMigrationEnabled,
Line 704:
AsyncDataProvider.getDefaultConfigurationVersion()))
Line 705: && (isVmMigratable() || !isLocalSD)) {
&&? You want isVmMigratable() to only be taken into account if !isLocalSD, and
as it's currently implemented one of them is enough to override hasCpuPinning
(i.e. whenever !isLocalSD, hasCpuPinning will be false no matter if the vm is
migratable or not).
Line 706: hasCpuPinning = false;
Line 707: }
Line 708:
Line 709: if (!hasCpuPinning) {
--
To view, visit http://gerrit.ovirt.org/20591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4706419295d67f7a022a85bc61f75bb46def2b6b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
