Vojtech Szocs has posted comments on this change. Change subject: webadmin: 'phase one' user portal and webadmin localization ......................................................................
Patch Set 15: Looks good to me, approved Alona, many thanks for your response, it explained all my questions. Regarding default properties files, now I understand that they're actually useful for translators, having a script that generates them is a good idea. Regarding 2 ways to localize View/UiBinder component, I also prefer doing localization inside View code. Up to now, localize() method was just a convention (not part of some component init code). Maybe we can think of some init/localize method in abstract View. For Gilad and Daniel, here are my comments: - separating this patch as Gilad proposed could be useful for reviewers, but at this stage, when Alona has everything ready, I guess we should leave it like this - I agree that we can localize search/tasks/events/alerts later on, in some 'phase two' patch -- To view, visit http://gerrit.ovirt.org/3612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74c56a3aed35dec0a378efc58a2e44569eff6089 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
