Vojtech Szocs has posted comments on this change. Change subject: webadmin: localization infrastructure ......................................................................
Patch Set 4: Looks good to me, but someone else must approve Regarding ApplicationPlaces change, since UiCommon model titles are now localized, we can use model hashName to be part of the final navigation token. Some detail models missed the hashName but Alona's localization patch added them, along with AbstractMainTabWithDetailsPresenter change, so it should be OK. -- To view, visit http://gerrit.ovirt.org/3783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70dbe074f39b48408bab5f6b050798731f573848 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
