Oved Ourfali has posted comments on this change. Change subject: core: manage-domains support the ldap provider type ......................................................................
Patch Set 1: (7 inline comments) .................................................... File backend/manager/conf/kerberos/engine-manage-domains Line 52: printf "\tengine-manage-domains -action=ACTION [-domain=DOMAIN -type=TYPE -user=USER -passwordFile=PASSWORD_FILE -interactive -configFile=PATH -addPermissions] -report\n" Perhaps we should use -provider instead of -type. As in the future we might use this utility also to manage non-LDAP domains? (not in the very near future, but we should think this through). Line 56: printf "\tTYPE (mandatory for add, optional for edit) the ldap type of server used for the domain.\n" write LDAP instead of ldap. Also, write the possible options. Line 66: printf "\t\t\tAdd a domain called example.com, using user admin with ldap server type as ipa(for freeIPA) and read the password from /tmp/.pwd.\n" ipa --> IPA. I would delete the freeIPA stuff. Also, I would give an example for active directory. Line 131: DomainsLDAPProviderTypes Didn't we change it to LDAPProviderTypes? .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/SimpleAuthenticationCheck.java Line 93: Why indentation here? .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java Line 49: return ""; very nice! .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java Line 272: return LdapProviderType.valueOf(parser.getArg(Arguments.type.name())); I guess it will make it case sensitive. Can we somehow make it case-insensitive? -- To view, visit http://gerrit.ovirt.org/3808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd4a792be7a70637e2c84ed8d86b6c658becada9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
