Martin Peřina has posted comments on this change.
Change subject: core:there are dos end of lines in engine.log
......................................................................
Patch Set 1:
(2 comments)
Btw I found that also these classes contain '\r' in log messages:
SPMAsyncTask
DownloadImageVDSCommand
UploadImageVDSCommand
CopyImageVDSCommand
Will you add them to this patch or should I create a new patch to fix this?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java
Line 27: getParameters().getImageType().name(),
Line 28: getParameters().getNewImageID().toString(),
Line 29: getParameters().getNewImageDescription(),
Line 30: Guid.Empty.toString(),
Line 31: Guid.Empty.toString());
1) Replace 'olFormat' with 'volFormat'
2) Calling Guid.toString() is unnecessary, it's called automatically
3) I would conform to max 120 chars per line
So I would change it to:
log.infoFormat(
"-- createVolume parameters: sdUUID={0} spUUID={1} imgGUID={2}
size={3} bytes volFormat={4}"
+ " volType={5} volUUID={6} descr={7} srcImgGUID={8}
srcVolUUID={9}",
getParameters().getStorageDomainId(),
getParameters().getStoragePoolId(),
getParameters().getImageGroupId(),
getParameters().getImageSizeInBytes(),
getParameters().getVolumeFormat().name(),
getParameters().getImageType().name(),
getParameters().getNewImageID(),
getParameters().getNewImageDescription(),
Guid.Empty,
Guid.Empty);
Line 32:
Line 33: // NOTE: The 'uuidReturn' variable will contain the taskID and
not the
Line 34: // created image id!
Line 35: uuidReturn = getIrsProxy().createVolume(
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java
Line 27: getParameters().getImageType().name(),
Line 28: getParameters().getNewImageID().toString(),
Line 29: getParameters().getNewImageDescription(),
Line 30: getParameters().getSourceImageGroupId().toString(),
Line 31: getParameters().getImageId().toString());
1) Calling Guid.toString() is unnecessary, it's called automatically
2) I would conform to max 120 chars per line
So I would change to this:
log.infoFormat(
"-- createVolume parameters: sdUUID={0} spUUID={1} imgGUID={2}
size={3} bytes volFormat={4}"
+ " volType={5} volUUID={6} descr={7} srcImgGUID={8}
srcVolUUID={9}",
getParameters().getStorageDomainId(),
getParameters().getStoragePoolId(),
getParameters().getImageGroupId(),
getParameters().getImageSizeInBytes(),
getParameters().getVolumeFormat().name(),
getParameters().getImageType().name(),
getParameters().getNewImageID(),
getParameters().getNewImageDescription(),
getParameters().getSourceImageGroupId(),
getParameters().getImageId());
Line 32:
Line 33: // NOTE: The 'uuidReturn' variable will contain the taskID and
not
Line 34: // the created image id!
Line 35: uuidReturn =
getIrsProxy().createVolume(getParameters().getStorageDomainId().toString(),
--
To view, visit http://gerrit.ovirt.org/20983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73eae1a3d76ffca00089ace3e9fc371950da30ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
