Lior Vernia has posted comments on this change. Change subject: webadmin : Removing instead of hiding virt-related fields in the host->general sub-tab ......................................................................
Patch Set 13: (5 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-10-28 13:47:28 +0530 Line 4: Commit: Anmol Babu <[email protected]> Line 5: CommitDate: 2013-11-06 21:51:02 +0530 Line 6: Line 7: webadmin : Removing instead of hiding virt-related fields in the host->general sub-tab This seems kinda long for a commit title, it should normally be under 50 characters. Maybe "Remove Virt fields in Gluster mode"? And only explain in the commit body where it was performed. Line 8: Line 9: Removing instead of hiding virt-related fields in the host -> general Line 10: Line 11: sub-tab and hence fix the allignment issues Line 7: webadmin : Removing instead of hiding virt-related fields in the host->general sub-tab Line 8: Line 9: Removing instead of hiding virt-related fields in the host -> general Line 10: Line 11: sub-tab and hence fix the allignment issues It seems like these lines were broken manually, could you please configure your text editor to break the lines automatically at 72 characters? So that gerrit doesn't interpret it as a new paragraph? Line 12: Line 13: Change-Id: I8023616e95d2b52a0c4f813037df1e7f10e6083f .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java Line 131: boolean virtSupported = ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly); Line 132: // Build a form using the FormBuilder Line 133: formBuilder = new FormBuilder(formPanel, 3, 7); Line 134: Line 135: int rowCount = -1; I would prefer this to start at 0, and following lines to do rowCount++ instead of ++rowCount. It makes it clearer to understand what value is used in each row (and specifically the first row). Line 136: Line 137: formBuilder.addFormItem(new FormItem(constants.osVersionHostGeneral(), oS, ++rowCount, 0)); Line 138: formBuilder.addFormItem(new FormItem(constants.kernelVersionHostGeneral(), kernelVersion, ++rowCount, 0)); Line 139: if (virtSupported) { Line 145: formBuilder.addFormItem(new FormItem(constants.spiceVersionHostGeneral(), spiceVersion, ++rowCount, 0, virtSupported)); Line 146: formBuilder.addFormItem(new FormItem(constants.isciInitNameHostGeneral(), iScsiInitiatorName, ++rowCount, 0, virtSupported)); Line 147: } Line 148: Line 149: rowCount = -1; Same. Line 150: Line 151: if (virtSupported) { Line 152: formBuilder.addFormItem(new FormItem(constants.spmPriority(), spmPriority, ++rowCount, 1, virtSupported)); Line 153: formBuilder.addFormItem(new FormItem(constants.activeVmsHostGeneral(), activeVms, ++rowCount, 1, virtSupported)); Line 157: formBuilder.addFormItem(new FormItem(constants.numOfSocketsHostGeneral(), numberOfSockets, ++rowCount, 1)); Line 158: formBuilder.addFormItem(new FormItem(constants.numOfCoresPerSocketHostGeneral(), coresPerSocket, ++rowCount, 1)); Line 159: formBuilder.addFormItem(new FormItem(constants.numOfThreadsPerCoreHostGeneral(), threadsPerCore, ++rowCount, 1)); Line 160: Line 161: rowCount = -1; Same. Line 162: Line 163: formBuilder.addFormItem(new FormItem(constants.physMemHostGeneral(), physicalMemoryDetails, ++rowCount, 2)); Line 164: formBuilder.addFormItem(new FormItem(constants.swapSizeHostGeneral(), swapSizeDetails, ++rowCount, 2)); Line 165: formBuilder.addFormItem(new FormItem(constants.sharedMemHostGeneral(), sharedMemory, ++rowCount, 2)); -- To view, visit http://gerrit.ovirt.org/20603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8023616e95d2b52a0c4f813037df1e7f10e6083f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
