Allon Mureinik has posted comments on this change.
Change subject: core: adding backup and restore scripts to dbscripts
......................................................................
Patch Set 2: (2 inline comments)
Minor: consider removing the old mssql utilities in a separate patch - one for
cleanups and a different one to add new functionality.
Also, note two inline comments - I believe this is a minor usability bug.
....................................................
File backend/manager/dbscripts/backup.sh
Line 24: printf "\t-d DATABASE - The database name
(def. ${DATABASE})\n"
the default username should be postgres, not "".
currently, if backup_db.sh is executed without specifying -u, you will execute,
e.g.:
g_dump -C -E UTF8 --column-inserts --disable-dollar-quoting
--disable-triggers --format=p -h localhost -p 5432 -U -f
engineMon_Apr_23_16:16:32_IDT_2012.sql engine
Note the consecutive -U -f. This will result in pg_dump failing with the error
pg_dump: too many command-line arguments (first is "engine")
....................................................
File backend/manager/dbscripts/restore.sh
Line 23: printf "\t-p PORT - The database port for the database
(def. ${PORT})\n"
same comment about the default user as in backup_db.sh
--
To view, visit http://gerrit.ovirt.org/3523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57ac38ee8d412fa86c8a35b03caf29ff452848b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
