Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Fixed issue with gluster task scheduler thread waiting
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
1 minor comment on test case
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
Line 140:
Line 141: tasksSyncJob.updateGlusterAsyncTasks();
Line 142: Mockito.verify(jobRepository,
times(0)).updateStep(any(Step.class));
Line 143: Mockito.verify(tasksSyncJob,
times(0)).endStepJob(any(Step.class));
Line 144: }
Dont we need to verify the execution of runInternalAction ?
Line 145:
Line 146: @Test
Line 147: public void testCreateTasksStartedFromCLIWithErrors() {
Line 148:
doReturn(getTasks(JobExecutionStatus.STARTED)).when(provider).getTaskListForCluster(CLUSTER_GUIDS[1]);
--
To view, visit http://gerrit.ovirt.org/20089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia94a2cccece1c0a45c46bbd7cc3e1e58c9aa379f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
