Alon Bar-Lev has posted comments on this change.

Change subject: engine: fix find_bugs non-transient variables on WelcomeServlet
......................................................................


Patch Set 1:

>> I believe that part of the servlet contract states that 'init' is always 
>> called after serialization

> If this correct then solution is valid, I could not find this, but maybe I am 
> looking in wrong documentation.

Hmmm... probably before de-serialization... right?

-- 
To view, visit http://gerrit.ovirt.org/21071
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71bbab70988cad7d8e2d2884633803f9cff3152b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to