Timothy Asir has posted comments on this change.
Change subject: gluster: add gluster host uuid along with host name/ip for
remove host
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 215: Guid glusterHostId =
Line 216: (glusterServer != null) ?
glusterServer.getGlusterServerUuid() : null;
Line 217: if (glusterHostId == null) {
Line 218: log.warnFormat("Could not find gluster host uuid for the
node {0}", hostName);
Line 219: }
Please check Sahina's comment in previous patch set which clarifies this.
Line 220: VDSReturnValue returnValue =
Line 221: runVdsCommand(
Line 222: VDSCommandType.RemoveGlusterServer,
Line 223: new
RemoveGlusterServerVDSParameters(runningHostInSourceCluster.getId(),
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 198: private void glusterHostRemove() {
Line 199: if (clusterHasMultipleHosts() && !hasVolumeBricksOnServer()) {
Line 200: GlusterServer glusterServer =
getGlusterServerDao().getByServerId(getVds().getId());
Line 201: Guid glusterHostId =
Line 202: (glusterServer != null) ?
glusterServer.getGlusterServerUuid() : null;
That line also performs glusterServer null check.
Line 203: if (glusterHostId == null) {
Line 204: log.warnFormat("Could not find gluster host uuid for
the node {0}",
Line 205: getVds().getHostName());
Line 206: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 211: public Map<String, Object> glusterVolumeRebalanceStop(String
volumeName);
Line 212:
Line 213: public Map<String, Object> replaceGlusterVolumeBrickStart(String
volumeName, String existingBrickDir, String newBrickDir);
Line 214:
Line 215: public Map<String, Object> glusterHostRemove(String hostName,
Boolean force, Map<String, String> option);
Yes, It should be options only. I will change this to options.
Line 216:
Line 217: public Map<String, Object> glusterVolumeReplaceBrickStart(String
volumeName, String existingBrickDir, String newBrickDir);
Line 218:
Line 219: public Map<String, Object> glusterHostAdd(String hostName);
--
To view, visit http://gerrit.ovirt.org/20731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I799333a16dfffaa6125aa6d498e4292cbb97cf48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
