Liran Zelkha has posted comments on this change.
Change subject: core: Add Kerberos authenticator
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/kerberos/KerberosConfiguration.java
Line 33: public static KerberosConfiguration getInstance() {
Line 34: if (instance == null) {
Line 35: synchronized (KerberosConfiguration.class) {
Line 36: if (instance == null) {
Line 37: instance = new KerberosConfiguration();
Why not create it in the instance declaration, and save the code and the
volatile?
Line 38: }
Line 39: }
Line 40: }
Line 41: return instance;
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/kerberos/KerberosJaasConfiguration.java
Line 19: public static KerberosJaasConfiguration getInstance() {
Line 20: if (instance == null) {
Line 21: synchronized(KerberosJaasConfiguration.class) {
Line 22: if (instance == null) {
Line 23: instance = new KerberosJaasConfiguration();
Why not use declaration initialization?
Line 24: }
Line 25: }
Line 26: }
Line 27: return instance;
--
To view, visit http://gerrit.ovirt.org/21030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4004e4a783530767b2f7682be17b3ce1e9a3802
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
