Allon Mureinik has posted comments on this change.

Change subject: core: Default DC & Cluster has fixed UUIDs
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

@Alon - I did not understand your comment. Is there or isn't there a problem 
with the registration servlet?

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 17: @ValidVdsGroup(groups = { CreateEntity.class })
Line 18: 
Line 19: public class VDSGroup extends IVdcQueryable implements Serializable, 
BusinessEntity<Guid>, HasStoragePool<Guid>, Nameable, Commented {
Line 20: 
Line 21:     private static final long serialVersionUID = 5659359762655478095L;
AFAIK, the serialVersionUID should be regenerated since you changed the class' 
signature.
Line 22: 
Line 23:     private Guid id;
Line 24: 
Line 25:     @NotNull(message = "VALIDATION.VDS_GROUP.NAME.NOT_NULL", groups = 
{ CreateEntity.class, UpdateEntity.class })


-- 
To view, visit http://gerrit.ovirt.org/21040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96c96f5692a9ba113f37f0f8b082aaee244b3ed7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to