Allon Mureinik has posted comments on this change.
Change subject: webadmin: Expose read-only disk functionality in UI.
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
Line 107: <e:EntityModelCheckBoxEditor
ui:field="wipeAfterDeleteEditor" addStyleNames="{style.checkBoxEditor}"/>
Line 108: <e:EntityModelCheckBoxEditor
ui:field="isBootableEditor" addStyleNames="{style.checkBoxEditor}" />
Line 109: <e:EntityModelCheckBoxEditor
ui:field="isShareableEditor" addStyleNames="{style.checkBoxEditor}"/>
Line 110: <e:EntityModelCheckBoxEditor
ui:field="isSgIoUnfilteredEditor" addStyleNames="{style.checkBoxEditor}"/>
Line 111: <e:EntityModelCheckBoxEditor
ui:field="isReadOnlyEditor" addStyleNames="{style.checkBoxEditor}"/>
The indentation here looks a bit fishy. Shouldn't this be aligned under
<e:EntityModelCheckBoxEditor ui:field="isBootableEditor" ?
Line 112: </g:VerticalPanel>
Line 113: </g:HorizontalPanel>
Line 114: <g:Label ui:field="message"
addStyleNames="{style.errorMessageLabel}" />
Line 115: <g:FlowPanel ui:field="externalDiskPanel"
addStyleNames="{style.externalDiskPanel}"/>
--
To view, visit http://gerrit.ovirt.org/20185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8d98df5e9b7aa8130b45b1ca036219175b70bf
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
