Omer Frenkel has posted comments on this change.
Change subject: core: change the retry to run failed HA VM frequency
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
Line 61: Guid vmId = vmIdAndDateTime.getFirst();
Line 62: EngineLock runVmLock = createLockForRunVmCommand(vmId);
Line 63:
Line 64: if (!getLockManager().acquireLock(runVmLock).getFirst()) {
Line 65: log.infoFormat("Could not acquire lock for running HA
VM {0}", vmId);
iirc, this will be written (~)every second to the log while the vm is locked,
this is too much.. maybe move to debug
Line 66: continue;
Line 67: }
Line 68:
Line 69: if (!runVm(vmId, runVmLock) &&
getVmDynamicDao().get(vmId).getStatus() == VMStatus.Down) {
--
To view, visit http://gerrit.ovirt.org/19500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f8914efc73ac1ea4f4a2ec4e588d778e9002451
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
