Arik Hadas has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images ......................................................................
Patch Set 2: Code-Review+1 The patch looks good. Regarding your comment in the commit message, on which command the template's disks aren't locked? we don't need to lock the disks in CreateSnapshotFromTemplateCommand because they are locked (with shared lock) in AddVmCommand. IMO we really should not use db locks anymore, and try to convert db locks to in-memory locks where we can (yeah, there's no way to show them in the UI currently, that's the drawback). -- To view, visit http://gerrit.ovirt.org/21100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
