Sahina Bose has posted comments on this change.
Change subject: gluster: compare GlusterAsyncTask in equals of Entities
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 131: && (ObjectUtils.objectsEqual(volumeId,
brick.getVolumeId()))
Line 132: && (ObjectUtils.objectsEqual(serverId,
brick.getServerId()))
Line 133: && (ObjectUtils.objectsEqual(brickDirectory,
brick.getBrickDirectory()))
Line 134: && (ObjectUtils.objectsEqual(brickOrder,
brick.getBrickOrder()))
Line 135: && (ObjectUtils.objectsEqual(getAsyncTask(),
brick.getAsyncTask()))
add in hashCode as well
Line 136: && status == brick.getStatus());
Line 137: }
Line 138:
Line 139: public void copyFrom(GlusterBrickEntity brick) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 414:
Line 415: if (!ObjectUtils.objectsEqual(getAsyncTask(),
volume.getAsyncTask())) {
Line 416: return false;
Line 417: }
Line 418:
add in hashCode method as well
Line 419: return true;
Line 420: }
Line 421:
Line 422: public GlusterBrickEntity getBrickWithId(Guid brickId) {
--
To view, visit http://gerrit.ovirt.org/21077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If85362b23057532ba69fe2b9f6d0e9c5d5753e2b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
