Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
......................................................................
Patch Set 11: Code-Review-1
(8 comments)
....................................................
File jobs/ovirt_engine_upgrade_params/update_engine_params.sh
Line 14:
Line 15:
Line 16: validate()
Line 17: {
Line 18: if [[ -z "${WORKSPACE}" \
Inconsistent indenting.
Line 19: || -z "${TO}" \
Line 20: || -z "${FROM}" ]]; then
Line 21: echo "Please provide 3 parameters to the job"
Line 22: exit 1
Line 69:
Line 70: configure_from_repo()
Line 71: {
Line 72: if [[ "${FROM}" == "stable" ]]; then
Line 73: cp "${STABLE_33_REPO}" /etc/yum.repos.d
This only works on fedora and the files are so simple that I think I'd build it
up here. Then you can use variables as well.
Line 74: fi
Line 75: }
Line 76:
Line 77:
Line 95: echo "Installing ${FROM} engine"
Line 96: ${ENGINE_SETUP}
Line 97: if [[ "${?}" -ne 0 ]]; then
Line 98: echo "SETUP_FAILED" >> "${LOG}"
Line 99: copy_log
trailing whitespace
Line 100: exit 1
Line 101: fi
Line 102: copy_log
Line 103: }
Line 98: echo "SETUP_FAILED" >> "${LOG}"
Line 99: copy_log
Line 100: exit 1
Line 101: fi
Line 102: copy_log
trailing whitespace
Line 103: }
Line 104:
Line 105:
Line 106: configure_to_repo()
Line 105:
Line 106: configure_to_repo()
Line 107: {
Line 108: if [[ "${TO}" == "nightly" ]]; then
Line 109: cp "${NIGHTLY_33_REPO}" /etc/yum.repos.d
Same here: fedora only.
Line 110: fi
Line 111: }
Line 112:
Line 113:
Line 106: configure_to_repo()
Line 107: {
Line 108: if [[ "${TO}" == "nightly" ]]; then
Line 109: cp "${NIGHTLY_33_REPO}" /etc/yum.repos.d
Line 110: fi
Inconsistent indenting
Line 111: }
Line 112:
Line 113:
Line 114: prepare_pgpass()
Line 112:
Line 113:
Line 114: prepare_pgpass()
Line 115: {
Line 116: cat << PGPASS > /root/.pgpass
This line could be indented
Line 117: localhost:5432:*:postgres:123456
Line 118: localhost:5432:*:engine:123456
Line 119: 127.0.0.1:5432:*:engine:123456
Line 120: 127.0.0.1:5432:*:postgres:123456
Line 119: 127.0.0.1:5432:*:engine:123456
Line 120: 127.0.0.1:5432:*:postgres:123456
Line 121: PGPASS
Line 122:
Line 123: chmod 600 /root/.pgpass
This line could be indented
Line 124: }
Line 125:
Line 126:
Line 127: remove_pgpass()
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1809bd55c88b17f1d7dfde3920212e6f046709a8
Gerrit-PatchSet: 11
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
