Michael Pasternak has posted comments on this change.

Change subject: restapi: Include charset in JSON Content-Type
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/JsonProvider.java
Line 77:             MultivaluedMap<String, Object> httpHeaders, OutputStream 
entityStream) throws IOException {
Line 78:         // Jackson always generates the output using UTF-8, regardless 
of what is requested, so we can safely set the
Line 79:         // charset to UTF-8:
Line 80:         httpHeaders.putSingle(CONTENT_TYPE_HEADER, CONTENT_TYPE_MEDIA);
Line 81:         super.writeTo(value, type, genericType, annotations, 
mediaType, httpHeaders, entityStream);
forgot to mention, if you'll use @Produces(), please check if it keeps accepting
application/X without  charset specified,

thanks.
Line 82:     }


-- 
To view, visit http://gerrit.ovirt.org/20104
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9156fe168451f103219902b821236b5a4703819d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to