Ori Liel has posted comments on this change.
Change subject: restapi: Migrates the brick data and mark it for deletion
......................................................................
Patch Set 12:
(5 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 3869: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks|rel=delete
Line 3870: description: get the list of all bricks in the gluster volume
attached to the cluster
Line 3871: request:
Line 3872: body:
Line 3873: parameterType: Bricks
This should be 'GlusterBricks', which is the name of the java class.
Line 3874: signatures:
Line 3875: - mandatoryArguments:
Line 3876: bricks--COLLECTION: {brick.id: 'xs:string'}
Line 3877: optionalArguments: {}
Line 3883: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/migrate|rel=migrate
Line 3884: description: migrate the data from the brick to others and mark
for deletion
Line 3885: request:
Line 3886: body:
Line 3887: parameterType: Bricks
This should be 'GlusterBricks', which is the name of the java class.
Line 3888: signatures:
Line 3889: - mandatoryArguments:
Line 3890: bricks--COLLECTION: {brick.name: 'xs:string'}
Line 3891: optionalArguments: {}
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 154: int replicaCount = bricks.isSetReplicaCount() ?
bricks.getReplicaCount() : 0;
Line 155: return performAction(VdcActionType.GlusterVolumeRemoveBricks,
Line 156: new
GlusterVolumeRemoveBricksParameters(asGuid(getVolumeId()),
Line 157: mapBricks(asGuid(getVolumeId()), bricks),
Line 158: replicaCount));
This is just whitespace change, right? I don't really care, but it's best no to
have such 'noise' in the patch. Up to you.
Line 159: }
Line 160:
Line 161: @Override
Line 162: public GlusterBrickResource getGlusterBrickSubResource(String
brickId) {
Line 190: GlusterVolumeEntity volumeEntity =
getEntity(GlusterVolumeEntity.class,
Line 191: VdcQueryType.GetGlusterVolumeById,
Line 192: new IdQueryParameters(entity.getVolumeId()),
Line 193: null,
Line 194: true);
whitespace.
Line 195:
Line 196: GlusterVolumeAdvancedDetails detailsEntity =
getEntity(GlusterVolumeAdvancedDetails.class,
Line 197: VdcQueryType.GetGlusterVolumeAdvancedDetails,
Line 198: new
GlusterVolumeAdvancedDetailsParameters(volumeEntity.getClusterId(),
Line 194: true);
Line 195:
Line 196: GlusterVolumeAdvancedDetails detailsEntity =
getEntity(GlusterVolumeAdvancedDetails.class,
Line 197: VdcQueryType.GetGlusterVolumeAdvancedDetails,
Line 198: new
GlusterVolumeAdvancedDetailsParameters(volumeEntity.getClusterId(),
whitespace
Line 199: volumeEntity.getId(),
Line 200: entity.getId(), true),
Line 201: null,
Line 202: true);
--
To view, visit http://gerrit.ovirt.org/19400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88f3402a25316d1717ee914aa77856fbe802db
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
