Ori Liel has posted comments on this change.
Change subject: restapi: Commit remove brick if migrate executed
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java
Line 41:
Line 42: private static final String serverName = "testServer";
Line 43: private BackendGlusterVolumeResource parentMock;
Line 44: private GlusterTestHelper helper;
Line 45: private static final String MIGRATE_BRICKS_ACTION_BASE_URL =
"/clusters/" + clusterId + "/glustervolumes/"
Whitespace - why start a new line?
Line 46: + volumeId;
Line 47:
Line 48: public BackendGlusterBricksResourceTest() {
Line 49: super(new BackendGlusterBricksResource(),
Line 176: }
Line 177:
Line 178: @Test
Line 179: public void testRemove() throws Exception {
Line 180: setUpGetEntityExpectations(VdcQueryType.GetGlusterVolumeById,
It would be great if you could add a test for delete which ends up not
executing, because of an ongoing migrate task (basically the other flow which
this patch adds)
Line 181: IdQueryParameters.class,
Line 182: new String[] { "Id" },
Line 183: new Object[] { volumeId },
Line 184: helper.getVolumeEntity(0));
--
To view, visit http://gerrit.ovirt.org/21043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7830749bb84f61dd1a80281d3abe6dc113150fd1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
